Fix leak when cURL PREREQFUNCTION returns a type other than int#22726
Open
Sjord wants to merge 2 commits into
Open
Fix leak when cURL PREREQFUNCTION returns a type other than int#22726Sjord wants to merge 2 commits into
Sjord wants to merge 2 commits into
Conversation
ndossche
reviewed
Jul 14, 2026
Sjord
requested review from
Girgias,
SakiTakamachi,
TimWolla,
arnaud-lb,
derickr,
devnexen,
dstogov and
kocsismate
as code owners
devnexen
removed request for
Girgias,
SakiTakamachi,
TimWolla,
arnaud-lb,
derickr,
devnexen,
dstogov and
kocsismate
The return value of the function registered with CURLOPT_PREREQFUNCTION was not cleaned up. Destroy the return value. Increase the returned string in the test so that the address sanitizer picks up the leak.
The CURLOPT_PREREQFUNCTION leak test returned a constant string value. Under opcache optimization, SCCP/constant folding may turn this into an interned string, which is process-lifetime allocated and therefore does not reliably trigger leak detection. Use a dynamically allocated array containing random_bytes() instead. This guarantees a non-interned, refcounted return value that exercises the missing zval_ptr_dtor() path consistently under leak analyzers.
Sjord
force-pushed
the
leak-curlopt-prereqfunction
branch
from
c7cf248 to
d7b9b3f
Compare
TimWolla
approved these changes
Jul 14, 2026
ndossche
changed the title
ndossche
approved these changes
Jul 14, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
thx
Note that the callbacks in curl all have a shared issue: none of them handles references correctly. This is not blocking for your PR of course, but should be fixed some day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of the function registered with CURLOPT_PREREQFUNCTION was not cleaned up. Destroy the return value. Increase the returned string in the test so that the address sanitizer picks up the leak.